-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of keycode depreciated per Vue docs #39
Comments
@hackerESQ we will look into it. |
I wouldn't mind taking this on in the Vue 3 branch once the PR for that is merged. |
semiaddict
added a commit
to philharmoniedeparis/v-hotkey
that referenced
this issue
Jan 16, 2023
Use KeyboardEvent.key instead. Closes: Dafrok#39
Open
I ended up implementing this change in my fork, and updated my PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Behind the scenes, this plugin uses keycodes.
While reading the vue docs, I discovered that key codes are actually being depreciated from browsers. See: https://vuejs.org/v2/guide/events.html#Key-Codes
Should this plugin be updated for the new implementation, which appears to use built in labels for each key type? E.g., left and right arrow are
ArrowLeft
andArrowRight
respectively.Is this on the radar for the plugin creator/maintainers? Are there any thoughts about this depreciation?
The text was updated successfully, but these errors were encountered: