Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawer type doc error #207

Open
scorninpc opened this issue Dec 11, 2018 · 0 comments
Open

Drawer type doc error #207

scorninpc opened this issue Dec 11, 2018 · 0 comments

Comments

@scorninpc
Copy link

scorninpc commented Dec 11, 2018

First of all, thank you for provide so nicely lib and so flexible. And sorry for my english

On the Drawer doc, if you use data-type="persistent" on the button, works fine, but when you open and close with javascript $('#navdrawerDefault').navdrawer('show'), this create overlay upside the menu and all page. Using data-type="persistent" on the div content, works like a charm

Url: https://daemonite.github.io/material/docs/4.1/material/navigation-drawer/#persistent-drawer
Actual code:

<button data-target="#navdrawerPersistent" data-toggle="navdrawer" data-type="persistent" type="button">Launch persistent drawer</button>

<div aria-hidden="true" class="navdrawer navdrawer-persistent" id="navdrawerPersistent" tabindex="-1">...</div>

Working code:

<button data-target="#navdrawerPersistent" data-toggle="navdrawer" type="button">Launch persistent drawer</button>

<div aria-hidden="true" class="navdrawer navdrawer-persistent" data-type="persistent" id="navdrawerPersistent" tabindex="-1">...</div>

I don't make the change and commit for revision, because I don't know if this is a error of code or error of documentation

Using button on header for open
image

Using javascript method
image

With my suggestion
image

@sesemaya sesemaya added the doc label Apr 4, 2019
@sesemaya sesemaya added this to the Backfilling Bootstrap v4.4.1 milestone Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants