-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TDQM hook with overrides #845
Labels
bug
Something isn't working
Comments
zilto
added
triage
label for issues that need to be triaged.
bug
Something isn't working
good first issue
Good for newcomers
and removed
triage
label for issues that need to be triaged.
labels
Apr 25, 2024
Hmm this might be a bit tricky -- we'll probably want to add a hamilton/hamilton/lifecycle/api.py Line 271 in 046ed59
Everything will be backwards compatible, but not super simple. |
This seems low priority, but good to have it documented! Thanks for the details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current behavior
When using
hamilton.plugins.h_tdqm.ProgressBar()
, the progress bar uses "the number of nodes to return" as denominator and "the number of nodes executed" as numerator. However, passing values to.execute(overrides=...)
counts towrds the first, but not the latter. Code runs to completion but the progress bar completes without reaching 100%Screenshots
Dataflow
Execution
The text was updated successfully, but these errors were encountered: