Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github license resolution fails for repos not using "master" #432

Open
alitheg opened this issue Oct 1, 2021 · 4 comments · May be fixed by #553
Open

Github license resolution fails for repos not using "master" #432

alitheg opened this issue Oct 1, 2021 · 4 comments · May be fixed by #553
Labels

Comments

@alitheg
Copy link

alitheg commented Oct 1, 2021

As lots of repos have now moved away from calling the default branch "master", this library fails Github license resolution for those libraries now. Perhaps the support ticket referenced in the code will get fixed, but if not it might be worth failing once and trying "main" too.

@coderpatros
Copy link
Member

Thanks for raising the issue. We should probably be checking what the default branch is first and just using that. I'm starting to work on the next major version. So I'll probably lump it in with that unless someone else wants to create a PR in the meantime.

@alitheg
Copy link
Author

alitheg commented Oct 1, 2021

You know, actually - I was looking deeper into the code so that I could see whether I could tackle a PR for it, and it looks like you just ignore references that aren't master, rather than using master blindly?

So that would mean there's still an issue in that it should accept main as well (which would be a simple or I think?), but it also means the issue I'm seeing isn't the fault of CycloneDX: on inspecting my nuspec file, I can see that the license is specified as coming from master, but they've changed their repository to using main on Github

@killi199
Copy link
Contributor

Main problem could be fixed with: #515. But all other branches besides main and master won't be fixed with that.

ecaisse added a commit to ecaisse/cyclonedx-dotnet that referenced this issue May 20, 2022
ecaisse added a commit to ecaisse/cyclonedx-dotnet that referenced this issue May 27, 2022
ecaisse added a commit to ecaisse/cyclonedx-dotnet that referenced this issue Jun 3, 2022
Copy link

github-actions bot commented Jan 7, 2024

This issue is stale because it has been open for 3 months with no activity.

@github-actions github-actions bot added the stale label Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants