Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 315: adding translations for some files #402

Merged
merged 3 commits into from
Oct 1, 2022

Conversation

superiorsd10
Copy link
Contributor

#315
I've added the translation for text in some files in the en-US.json. They're in the application folder.

Copy link
Member

@guyluz11 guyluz11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes, everything else looks good.

@superiorsd10
Copy link
Contributor Author

@guyluz11 Okay! I'll be doing that.

Copy link
Member

@guyluz11 guyluz11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes

@@ -6,6 +6,7 @@ import 'package:cybear_jinni/domain/user/all_homes_of_user/all_homes_of_user_ent
import 'package:cybear_jinni/domain/user/all_homes_of_user/all_homes_of_user_value_objects.dart';
import 'package:cybear_jinni/domain/user/i_user_repository.dart';
import 'package:dartz/dartz.dart';
import 'package:easy_localization/easy_localization.dart';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed any more as we removed the translation

"Turning_On_boiler": "Turning On boiler",
"Turning_Off_boiler": "Turning Off boiler",
"Waiting_for_user_to_get_connected_to_WiFi": "Waiting for user to get connected to WiFi",
"allInSameRoom": "allInSameRoom",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed any more as we removed the translation

"Waiting_for_user_to_get_connected_to_WiFi": "Waiting for user to get connected to WiFi",
"allInSameRoom": "allInSameRoom",
"Can't_add_unsupported_device": "Can't add unsupported device",
"home": "home",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can keep that one

@guyluz11 guyluz11 merged commit 330455d into CyBear-Jinni:dev Oct 1, 2022
@guyluz11 guyluz11 added the hacktoberfest-accepted Accept for hacktoberfest label Oct 1, 2022
@guyluz11 guyluz11 linked an issue Oct 1, 2022 that may be closed by this pull request
@guyluz11
Copy link
Member

guyluz11 commented Oct 3, 2022

Thanks for the pr

and happy Hacktoberfest 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accept for hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not all of the app support translation
2 participants