Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log client types of users. #115

Open
1 task done
juncture6825 opened this issue Jan 25, 2024 · 1 comment
Open
1 task done

Log client types of users. #115

juncture6825 opened this issue Jan 25, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@juncture6825
Copy link

Is there an existing feature request for this?

  • I have searched the existing issues before opening this feature request.

Describe the feature you would like to see.

A Minecraft client sends a string to the server which contains the client type (forge/fabric/optifine/vanilla/etc), version, and list of mods installed if applicable. I've listed an open source plugin below that does this.

This should be logged, it would be useful to see what's the most common client or what's the most common version (if you run ViaVersion for example). Currently no Minecraft metrics logger like PLAN support this, but I feel like this would give Unified Metrics an edge over the alternatives.

It would be nice if this was logged and you could visualize it with a chart on Grafana.

Client Detector Plugin: https://www.spigotmc.org/resources/clientdetector-client-mod-detection-forge-mod-detection-clientcontrol.90375/

How would you like to see this implemented?

Logs client info into Prometheus database.

Additional information to this request.

No response

@juncture6825 juncture6825 added the enhancement New feature or request label Jan 25, 2024
@Cubxity
Copy link
Owner

Cubxity commented Jan 25, 2024

The client brand can easily be measured via the various server APIs supported by UnifiedMetrics. However, client brand would possibly have high cardinality and may pose some issues since it's user-controlled and this may be used by the user to exhaust your storage/resources.

That being said, this is a valid suggestion and may be implemented as a non-default option in the config, or an extension plugin on top of UnifiedMetrics in the future. If anyone is interested in implementing this, feel free to comment in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants