Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Option for features (ssl and compression) is shown as boolean by cmake but uses as list of strings #737

Open
gittiver opened this issue Jan 6, 2024 · 0 comments · May be fixed by #770
Assignees
Labels
feature Code based project improvement

Comments

@gittiver
Copy link
Member

gittiver commented Jan 6, 2024

Each feature shall be represented by a boolean flag, i.e.

CROW_FEATURE_ENABLE_HTTPS
CROW_FEATURE_ENABLE_HTTP_COMPRESSION

instead of the usage as string list which adds additional error cases for not found features.

@gittiver gittiver added the feature Code based project improvement label Jan 6, 2024
@gittiver gittiver self-assigned this Jan 6, 2024
@gittiver gittiver linked a pull request Feb 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Code based project improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant