Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoundJS 2.0 uses loops instead of loop #319

Open
probityrules opened this issue Aug 21, 2019 · 0 comments
Open

SoundJS 2.0 uses loops instead of loop #319

probityrules opened this issue Aug 21, 2019 · 0 comments

Comments

@probityrules
Copy link

For backwards compatibility, I might recommend making this options.loop instead of options.loops. Unless maybe it's going to behave functionally different from the original 1.0 loop property?

let loops = Number(options.loops);

(It took me some time to figure out that the spec for this changed, so I wanted to note it here.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant