Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow "Stroke" appears on top of shape when using fill and strokestyle. #1066

Open
jerwolff opened this issue Jan 24, 2022 · 4 comments
Open
Assignees

Comments

@jerwolff
Copy link

Issue Details

  • Version used (Ex; 1.0): 1.0.0

  • Describe whats happening (Include any relevant console errors, a Gist is preferred for longer errors):

If you add a Shadow to a shape with Strokestyle and Fill, a " Shadow Stroke" appears on top of the shape.

shadowissue

Fiddle

  • OS & Browser version (Please be specific) (Ex; Windows 10 Home, Chrome 62.0.3202.94):

Windows 11 Pro Insider
Chrome 97.0.4692.99

  • Do you know of any workarounds?

If you remove the strokestyle, the shadow works as expected. So my current workaround is to draw a second shape for just the border.

@dijitaletkinlikler
Copy link

Zimjs createjs üzerine kurulu bir kütüphane. Bence zimjs'i kullanma.
zimjs.com

@danzen
Copy link
Contributor

danzen commented Mar 22, 2022

Yes - agreed - that has been a long standing issue - I think it is CreateJS based, not ZIM based, but it does happen in ZIM too. @dijitaletkinlikler - sorry, what did you mean to say in your response?

@dijitaletkinlikler
Copy link

I am sad. I don't know English so I use google translate. Sometimes it mistranslates. zimjs is a library built on createjs. I meant use zimjs instead of createjs.

@danzen
Copy link
Contributor

danzen commented Mar 23, 2022

lol - thanks @dijitaletkinlikler - we were wondering! This issue with the shadow of the border being above the shape has been around for a while, we have just put up with it. To this day, I make two shapes, one without the border that I put behind and add the shadow and then a shape with the border on top that I do not add the shadow. I think we built that in to ZIM Buttons but never solved the core issue. Maybe one day, I can dig into the CreateJS code and see what is causing it... or if anyone here has a solution, please let us know and we can update the code.

@danzen danzen self-assigned this Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants