@svinkle let me know if this is any better, I tried adding the external link icon but it broke the link functionality - do you think we are good to skip the icon for this?

@jordanAtShopify The code looks good to me but links are not being generated as I'd expect. Neither are the headings. Is this overriding what the markdown component is generating?

@svinkle this should just be overriding the default rendering behavior of the react-native-markdown-display package. When you say Links / Headers not being generated as expected you mean that you don't see the accessibility additions when using voice over tools?

you don't see the accessibility additions when using voice over tools

Exactly. The very top header has the correct accessibilityRole applied, but others do not. Also, links still appear to be purely underlined text. They should be singled out as interactive elements.

You can test this by going to Xcode → Open Developer Tool → Accessibility Inspector → click the cross-hair icon → hover over the content in question.

@henrytao-me what difference would having it in json make?

what difference would having it in json make?

One central place for translation?

Ah, ya the issue with the json file is that it doesn't support multiline strings and markdown depends on that for formatting. Also, we want it to be as easy as possible to just copy/paste the privacy policy in so we want to avoid any manual formatting steps and keep it close as possible to the original markdown format.