Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for supported languages when deployment #29

Open
henrytao-me opened this issue May 23, 2020 · 3 comments
Open

Add configuration for supported languages when deployment #29

henrytao-me opened this issue May 23, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@henrytao-me
Copy link
Member

What?

The repo could have a lot of translations, however it might not be necessary to use all of them when deployment. We should have a configuration for:

  • Default language: hardcoded or use device settings.
  • List of supported languages.

If there are only two languages, a toggle should be applied. If there are more than two languages, a picker should be applied.

@henrytao-me henrytao-me added the enhancement New feature or request label May 23, 2020
@akinncar
Copy link

akinncar commented May 26, 2020

I can implementing Portuguese Brazilian translation. I will start work in this now.

The toggle what you say is only on Introductions Scene, can we maybe change the select toggle to a list like menu in main screen?

@candidosales
Copy link
Contributor

@akinncar, it's already done in this PR: #25

@henrytao-me
Copy link
Member Author

There is additional works after PR #25, but I need to coordinate with UX team to finish it. Thanks Akinn and Candido

@henrytao-me henrytao-me self-assigned this May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants