Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tap on turn on notification does nothing if user block notification in settings on iOS #163

Open
henrytao-me opened this issue Jun 26, 2020 · 2 comments
Labels
enhancement New feature or request iOS

Comments

@henrytao-me
Copy link
Member

What?

If user blocks notification in settings iOS, the app show Notifications are OFF. Tap on it does nothing because we haven't handled it.

Follow up of #160

Suggestion

  • Change UI to Notifications are BLOCKED.
  • Tap on it should open Settings screen.

cc @emilybulger @AdamWhitcroft @gavrix @jordanAtShopify

@emilybulger
Copy link
Member

I don't think BLOCKED is right.

It should say OFF, but open Settings screen.

We are staying away from enable/disable/allow/block/etc in favor of consistent and clear ON/OFF. Tapping on any UI with that terminology takes you to the right place to update it (Settings in this case).

@henrytao-me

@henrytao-me
Copy link
Member Author

I see. That works. 👍 I will make a change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request iOS
Projects
None yet
Development

No branches or pull requests

2 participants