Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoffeeScriptRedux extends compilation handling breaking coverage #19

Open
samuelhorwitz opened this issue May 29, 2014 · 2 comments
Open

Comments

@samuelhorwitz
Copy link

michaelficarra/CoffeeScriptRedux#314

I don't know if this is on Ibrik's end or CSR's end, but I've submitted the issue to CSR since it originates in their code. On Ibrik's end, it may be necessary (depending on what CSR says is expected behavior) to somehow clean out the CSR instance between files.

To sum up the other issue, essentially having a file with extends will cause every subsequently processed Coffeescript file to include the helper functions that extends needs when compiled to JS. This causes code coverage to report otherwise 100% covered files as being incompletely covered despite every line in the reports being green because the boilerplate functions like isOwn$ and extends$ are never reached by files that don't actually need to use these.

@samuelhorwitz
Copy link
Author

This was apparently fixed with the release of 2.0.0 and the move away from CSR. Seems to work for me.

However, one more issue is it would be great if full coverage was reported when the CS extends helper is compiled into the actual source. Currently, coverage is impossible to be at 100% on any extended class because of the conditional branches introduced by the compiler.

@samuelhorwitz
Copy link
Author

Just as a note, in regards to the extends syntax, I have pushed up a patch in the form of a PR a while ago, that people can use as needed #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant