Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate output filenames: fullscreen when using MediaElement #1862

Closed
jfversluis opened this issue May 6, 2024 · 10 comments · Fixed by #1868
Closed

Duplicate output filenames: fullscreen when using MediaElement #1862

jfversluis opened this issue May 6, 2024 · 10 comments · Fixed by #1868
Labels
bug Something isn't working 📽️ MediaElement Issue/PR that has to do with MediaElement

Comments

@jfversluis
Copy link
Member

jfversluis commented May 6, 2024

It seems that with the latest nightly (and maybe even stable now?) there are sometimes issues with a duplicate file name for the fullscreen icon file that is used in MediaElement.

We need to investigate how this happens and how to get rid of it!


[...] I am getting this error: Error: One or more duplicate file names were detected. All image output filenames must be unique: fullscreen (/{path}/.nuget/packages/communitytoolkit.maui.mediaelement/99.0.0-build-1813.105074/buildTransitive/Images/fullscreen.svg), fullscreen (/{path}/.nuget/packages/communitytoolkit.maui.mediaelement/99.0.0-build-1813.105074/buildTransitive/Images/fullscreen.svg)

Any ideas?

Originally posted by @briankanelson in #1110 (comment)

@jfversluis jfversluis added bug Something isn't working 📽️ MediaElement Issue/PR that has to do with MediaElement labels May 6, 2024
@ne0rrmatrix
Copy link
Contributor

Can you provide more info? I created a sample project and tried both media element from latest source (99.0.0-preview1839) and from current release 3.1.1. I had zero issues. Is there a specific setting I need to set in csproj file? I am trying with <MauiVersion>8.0.21</MauiVersion> I tried <MauiVersion>8.0.14</MauiVersion> with the same result.

BTW #1813 was merged last week and is/was a PR that fixes ios crash issues and if you want to test the pr where the file was added you can test #1692 which added full screen support. Testing again earlier versions might be useful as you should get zero reference to file at all. It did not exist then.

@luisabreu84
Copy link

Can you provide more info? I created a sample project and tried both media element from latest source (99.0.0-preview1839) and from current release 3.1.1. I had zero issues. Is there a specific setting I need to set in csproj file? I am trying with <MauiVersion>8.0.21</MauiVersion> I tried <MauiVersion>8.0.14</MauiVersion> with the same result.

BTW #1813 was merged last week and is/was a PR that fixes ios crash issues and if you want to test the pr where the file was added you can test #1692 which added full screen support. Testing again earlier versions might be useful as you should get zero reference to file at all. It did not exist then.

@ne0rrmatrix could you please take a look to this comment, i described how you can reproduce it. Thanks.
#1110 (comment)

@ne0rrmatrix
Copy link
Contributor

Can you provide more info? I created a sample project and tried both media element from latest source (99.0.0-preview1839) and from current release 3.1.1. I had zero issues. Is there a specific setting I need to set in csproj file? I am trying with <MauiVersion>8.0.21</MauiVersion> I tried <MauiVersion>8.0.14</MauiVersion> with the same result.
BTW #1813 was merged last week and is/was a PR that fixes ios crash issues and if you want to test the pr where the file was added you can test #1692 which added full screen support. Testing again earlier versions might be useful as you should get zero reference to file at all. It did not exist then.

@ne0rrmatrix could you please take a look to this comment, i described how you can reproduce it. Thanks. #1110 (comment)

I cannot replicate the issue without a sample. I have tried both the sample app from repo and I created my own. I have had zero success at creating the bug. Please provide or attach a sample that clearly demonstrates the issue.

@luisabreu84
Copy link

Can you provide more info? I created a sample project and tried both media element from latest source (99.0.0-preview1839) and from current release 3.1.1. I had zero issues. Is there a specific setting I need to set in csproj file? I am trying with <MauiVersion>8.0.21</MauiVersion> I tried <MauiVersion>8.0.14</MauiVersion> with the same result.
BTW #1813 was merged last week and is/was a PR that fixes ios crash issues and if you want to test the pr where the file was added you can test #1692 which added full screen support. Testing again earlier versions might be useful as you should get zero reference to file at all. It did not exist then.

@ne0rrmatrix could you please take a look to this comment, i described how you can reproduce it. Thanks. #1110 (comment)

I cannot replicate the issue without a sample. I have tried both the sample app from repo and I created my own. I have had zero success at creating the bug. Please provide or attach a sample that clearly demonstrates the issue.

See attahcments.

Open Solution -> Run for iOS
Debug - Any CPU | iPhone Simulator

Output
1>Microsoft.Maui.Resizetizer.After.targets(623,9): Error : One or more duplicate file names were detected. All image output filenames must be unique: fullscreen (/Users/.../.nuget/packages/communitytoolkit.maui.mediaelement/3.1.1/buildTransitive/Images/fullscreen.svg)

Screenshot 2024-05-06 at 9 26 28 AM

CommunityToolkitPckgTest.zip

@ne0rrmatrix
Copy link
Contributor

I looked at the provided sample. Can verify that when you add a class library to an existing project where both have media element in both projects you will get an error about duplicate file names. I will investigate the issue.

@ne0rrmatrix
Copy link
Contributor

possibly related issue found here: dotnet/maui#19840 Will investigate further and see if they are related.

@luisabreu84
Copy link

Hi @ne0rrmatrix! any possible date to release this change? Thanks!

@luisabreu84
Copy link

hello! any news here?
Thanks!

@ne0rrmatrix
Copy link
Contributor

@luisabreu84 I am waiting on review and it looks good to go. Just need approval and then a maintainer with write privileges needs to push the changes.

@bijington
Copy link
Contributor

I've approved with one minor comment 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 📽️ MediaElement Issue/PR that has to do with MediaElement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants