Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACL oracle should return true if the hatch state is pending or closed #8

Open
sembrestels opened this issue Oct 26, 2021 · 1 comment
Milestone

Comments

@sembrestels
Copy link
Contributor

canPerform() may want to include who is a token holder or other authentication—at the moment if the Hatch app is set as an ACL Oracle, any address will be able to use the granted functionality once the vesting period is complete. -> This was done to allow votes to be (eventually) created even if something catastrophic happened to the Hatch app during fundraising. Consider changing this to be just the initial sale period, rather than full vesting date.

Note: It may be more interesting to avoid creating votes when the hatch is ongoing, checking if the hatch is either pending or closed.

@sembrestels sembrestels added this to the v2 milestone Oct 26, 2021
@sembrestels
Copy link
Contributor Author

Changing this would also imply change Impact Hours, the Hatch Template, and many documentation, so we leave it for a future version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant