-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make close()
permissionless
#7
Labels
Milestone
Comments
Changing this implies changes in the Impact Hours, Hatch Template, and many documentation. We leave it for the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From Sohkai's review: Does
close()
need to be guarded by a role? Wouldn't it be better if anyone could call it? Worried that the account who needs to callclose()
never does.Note:
close()
is being used by a separate app, to finalize the initial fundraise. Consider changing the functionality in the separate app to read from a closedHatch
than requiring only that app to callclose()
.The text was updated successfully, but these errors were encountered: