-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check timeSinceOpen()
properly
#6
Labels
Comments
If we change this check, many tests will fail, as at the end of the hatch period the state should be or Goal Reached or Refunding. I think changing this check changes the specification, and this could have unintended consequences. Was changing this check a strong advice? Is it affecting something else than just the deadline in which somebody can contribute? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From Sohkai's review:
State.Funding
state should still be present when_timeSinceOpen() == period
(i.e. more correct as_timeSinceOpen() <= period
).The text was updated successfully, but these errors were encountered: