Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use .call() with value instead of .transfer() #4

Open
sembrestels opened this issue Oct 26, 2021 · 0 comments · May be fixed by #17
Open

Use .call() with value instead of .transfer() #4

sembrestels opened this issue Oct 26, 2021 · 0 comments · May be fixed by #17
Labels
bug Something isn't working Sohkai's review

Comments

@sembrestels
Copy link
Contributor

From Sohkai's review: Avoid using address.transfer() (in _transfer() and _contribute()): these gas-limited methods are now generally seen as an anti-pattern and re-entrancy guards should instead be used when there are concerns with re-entrancy.
@sembrestels sembrestels added Sohkai's review bug Something isn't working labels Oct 26, 2021
sembrestels added a commit that referenced this issue Oct 27, 2021
@sembrestels
Use .call() with value instead of .transfer() (fixes #4)
2271de8
@sembrestels sembrestels linked a pull request Oct 27, 2021 that will close this issue
Fixes to Sohkai review #17
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Sohkai's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes to Sohkai review CommonsSwarm/hatch-app
1 participant
@sembrestels