Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 馃憖 with 鉂わ笍 when response is completed #882

Closed
ntindle opened this issue Apr 24, 2024 · 2 comments
Closed

Replace 馃憖 with 鉂わ笍 when response is completed #882

ntindle opened this issue Apr 24, 2024 · 2 comments
Labels

Comments

@ntindle
Copy link

ntindle commented Apr 24, 2024

Having a finalized state would be awesome so I know its done processing at a glance

@mrT23
Copy link
Collaborator

mrT23 commented Apr 24, 2024

by default we are doing something clearer than the icon - for each persistent tool (/review, /describe, ...) we are sending an updated message.
So I am not sure if there is a great need of also changing the icon

For example
#872 (comment)

image
image

@mrT23
Copy link
Collaborator

mrT23 commented Apr 24, 2024

In addition, the default, and by the far the most common, usage of PR-Agent is triggering the /describe, /review, /improve tools automatically when a new PR is opened, so the icons are not relevant there

@mrT23 mrT23 added the answered label Apr 24, 2024
@mrT23 mrT23 closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants