Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GITLAB] Aggregate review comments and shoot in 1 as generally the MR review works in Gitlab #307

Open
pushpanktugnawat opened this issue Sep 15, 2023 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@pushpanktugnawat
Copy link

Hello Guys,

First of all Thanks to everyone involved in making my life easy by integrating this tool with Gitlab specifically @okotek and @idavidov. It's working in a good manner so far sometimes it fails but it revives again.

I am back again as I am not sure if it's an issue or an improvement that maybe we can incorporate in the PR-AGENT or if you guys can guide me on how to enable it (if it already exists).

Whenever the PR-Agent does the code reviews it generates a comment and shoots an email for every comment which is pretty annoying for everyone to receive a huge amount of email every time causing the lack of usefulness of this tool.

Can we somehow enable a way to aggregate all comments in one i.e. the way normal reviews work in GitLab is you are capable of submitting your reviews until you are done with your reviews and release it in one shoot?

Can we make PR-Agent as well more efficient to do the same? Please shoot me if you have any questions I am happy to assist and answer.

Image for reference:

Screenshot 2023-09-15 at 4 26 00 PM
@pushpanktugnawat
Copy link
Author

I think it's happening as I used the inline code comments and for each comment, I am receiving an email. Can I follow some review methodology that will not comment but mark every review comment as a review?

@pushpanktugnawat
Copy link
Author

@mrT23 could you please help me here?

@okotek okotek added the help wanted Extra attention is needed label Oct 26, 2023
@okotek
Copy link
Contributor

okotek commented Oct 26, 2023

We did implement this in GitHub and BitBucket, it's on our list for GitLab as well, but it's not a top priority, and we could use community support for this. I'll update this issue when we'll have news.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants
@okotek @pushpanktugnawat and others