Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Include /review -i in GitHub App automation #157

Open
esauser opened this issue Jul 29, 2023 · 7 comments
Open

[Feature Request] Include /review -i in GitHub App automation #157

esauser opened this issue Jul 29, 2023 · 7 comments

Comments

@esauser
Copy link

esauser commented Jul 29, 2023

The GitHub App automatically runs /review when a PR is opened, but it does not do anything to subsequent pushes to the PR. We'd like to run /review -i for each subsequent push.

@bperreault
Copy link

I would like to add perhaps it could be an option. I prefer to re-request review personally.

@idavidov
Copy link
Contributor

i believe #215 is right for this purpose correct @tjwp ?

@tjwp
Copy link
Contributor

tjwp commented Aug 18, 2023

This would need some additional changes to handle incremental. It would need to look for a synchronize action on a PR and trigger an incremental review (only available by arg currently). It should probably be an additional setting.

@mrT23
Copy link
Collaborator

mrT23 commented Oct 3, 2023

i am not sure you would like review to be run automatically every new commit. it can flood the git with a lot(!) of messages.

my suggestion - use it manually, when needed.

@esauser
Copy link
Author

esauser commented Oct 5, 2023

This can almost be accomplished already. synchronize can be added to the handle_pr_actions and improve -i can be added to pr-commands. The only thing missing is being able to do it differently the first time vs. every time.

If the config was separated out to allow you to specify specific commands for specific actions we'd have that flexibility. Maybe something to consider @mrT23 .

@mrT23
Copy link
Collaborator

mrT23 commented Oct 5, 2023

Technically its possible, i agree.

However, optional features still need to be viable.
In practice, even as an option, would you really want 10-20 long review feedback messages in a single PR ?
we tried this way (Triggering on every commit) when starting developing pr-agent, and it was awful

I think a better option is to enable to update the initial review message after every commit, so review feedback will always be up-to-date.

but I am not sure. open for feedback

@esauser
Copy link
Author

esauser commented Oct 5, 2023

@mrT23 I would expect it to update existing, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants
@bperreault @tjwp @idavidov @mrT23 @esauser and others