-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should the controller expect Domain Errors from the command bus? #116
Comments
To be precise, this implementation will work if you use Kafka but will never trigger the bad request catch. If Kafka itself is unavailable it will respond with internal server error though. |
I also would like to know how errors in a boundex context are sent to other when you send command. In the course "DDD en TypeScript: Comunicación entre servicios y aplicaciones" this is not explained 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
You have this at the CoursePutController.ts#L20:
Right now this works because we are using an
InMemoryCommandBus
implementation. But, if we change the CommandBus implementation to one where we cannot expect the execution of the code (for example if we store this command in Kafka for later consumption), the implementation of this controller wouldn't work at all (because the use case will never get executed in this request, and it will never throw).Is this true? Thanks!
The text was updated successfully, but these errors were encountered: