-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch L9-Start wrong values in inStock() #22
Comments
amouratoglou
changed the title
Branch L9-Start
Branch L9-Start wrong values in inStock()
Jan 16, 2021
Nice find! Looks like this was fixed in this Pull Request: #4 |
Hi, It seems that the error has not been corrected. |
Still waiting on this error to be corrected. Also picked it up today more than a year later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey guys, great tutorial!!
I have noticed that L9-Start , which should have the finished code of L8, on main.js line 30 it doesn't have the right value on the computed property inStock(). It is set to look for the property image
instead of quantity
This might be confusing and frustrating for some users that need to compare their code with finished code and also, doesn't allow starting the lesson with fully working code.
https://github.com/Code-Pop/Intro-to-Vue-3/tree/L9-start
Current code:
Correct code:
Is there any way to contribute to the repo?
thanks
The text was updated successfully, but these errors were encountered: