Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display issue in log when using translations #4943

Closed
tooomm opened this issue Nov 18, 2023 · 2 comments · May be fixed by #4945
Closed

Display issue in log when using translations #4943

tooomm opened this issue Nov 18, 2023 · 2 comments · May be fixed by #4945
Labels
Bug

Comments

@tooomm
Copy link
Member

tooomm commented Nov 18, 2023 •
edited

System Information:
Client Version: 2.9.0-custom(9cbb905) (2023-11-17)
Client Operating System: Windows 11 Version 22H2
Build Architecture: 64-bit
Qt Version: 6.5.3
System Locale: en_DE
Install Mode: Standard

When not using English language, card names are not always properly separated in the logs. For certain actions, there is no space after the card name and the zone it's going:
image

image

Steps to reproduce:

  • Select EN
  • Move cards around zones
  • Select GER
  • Move cards around zones
@tooomm tooomm added the Bug label Nov 18, 2023
@ebbit1q
Copy link
Member

ebbit1q commented Nov 18, 2023

this isn't some bug, this is because the translation is not including the space:

    <message> 
        <location filename="src/messagelogwidget.cpp" line="81"/>
        <source> from their hand</source>
        <translation>von ihrer Hand</translation>
    </message>

@ebbit1q ebbit1q closed this as completed Nov 18, 2023
@tooomm tooomm mentioned this issue Nov 19, 2023
Draft
@tooomm
Copy link
Member Author

tooomm commented Nov 19, 2023 •
edited

Smart to also look into the translation files! I did only check Transifex... and indeed, it's barely visible there. That's obviously an issue for translators:
image



image
Most languages do not include the space in their translations currently!

This looks like a problem which requires a fix in the code. We do not want to have leading or trailing blanks in our source strings and make life for translators difficult, or make people complain about the log as a result of somebody not copying the space into the translation as well.

I tried a fix in #4945.
Would be happy if you can have a look and let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix spacing issue in message log strings Cockatrice/Cockatrice
2 participants
@tooomm @ebbit1q