Dark theme #368

frostius · 2021-04-28T00:51:32Z

Any chance of a dark theme?

Mabus13 · 2021-04-28T09:42:06Z

Yep yep yep!!! I want it tooooooooooooooo ^_________^

janwilmans · 2021-04-28T11:30:21Z

I will investigate, but I fear the worst, I never took application specific themes into account when we started this project, so the theme changes with the windows theme. Also, I am trying to focus my time to debug.vision a next generation version of debugview++, so maybe we can do something there.

frostius · 2021-04-29T13:22:27Z

The ability to change the font color and log background would be a big improvement if a true dark theme is not feasible.

This is the only development app I use that doesn't have a dark mode. At night when the room is dark, its like a spotlight shining out of my monitor.

janwilmans · 2021-04-29T13:35:40Z

good idea, I guess to work also need to persist this option?

…

On Thu, Apr 29, 2021, 15:22 Matt Frost ***@***.***> wrote: The ability to change the font color and log background would be a big improvement if a true dark theme is not feasible. This is the only development app I use that doesn't have a dark mode. At night when the room is dark, its like a spotlight shining out of my monitor. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#368 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABNITBBGHCIENYZ4NGSB2LLTLFMSXANCNFSM43WBCCLQ> .

frostius · 2021-04-29T14:44:22Z

For sure, theme persistence would be nice. On that note, persisting the screen location/dimensions would be a nice-to-have as well.

…

------ Original Message ------ From: "Jan Wilmans" ***@***.***> To: "CobaltFusion/DebugViewPP" ***@***.***> Cc: "Matt Frost" ***@***.***>; "Author" ***@***.***>

Sent: 4/29/2021 9:36:03 AM Subject: Re: [CobaltFusion/DebugViewPP] Dark theme (#368) good idea, I guess to work also need to persist this option? On Thu, Apr 29, 2021, 15:22 Matt Frost ***@***.***> wrote: > The ability to change the font color and log background would be a big > improvement if a true dark theme is not feasible. > > This is the only development app I use that doesn't have a dark mode. At > night when the room is dark, its like a spotlight shining out of my monitor. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#368 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABNITBBGHCIENYZ4NGSB2LLTLFMSXANCNFSM43WBCCLQ> > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#368 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA5EK4WRGRACMJUF2K5XCNDTLFOEHANCNFSM43WBCCLQ>.

janwilmans · 2021-04-29T18:23:48Z

I should already persist the screen location? doesn't it?

…

On Thu, Apr 29, 2021, 16:44 Matt Frost ***@***.***> wrote: For sure, theme persistence would be nice. On that note, persisting the screen location/dimensions would be a nice-to-have as well. ------ Original Message ------ From: "Jan Wilmans" ***@***.***> To: "CobaltFusion/DebugViewPP" ***@***.***> Cc: "Matt Frost" ***@***.***>; "Author" ***@***.***> Sent: 4/29/2021 9:36:03 AM Subject: Re: [CobaltFusion/DebugViewPP] Dark theme (#368) > >good idea, I guess to work also need to persist this option? > >On Thu, Apr 29, 2021, 15:22 Matt Frost ***@***.***> wrote: > > > The ability to change the font color and log background would be a >big > > improvement if a true dark theme is not feasible. > > > > This is the only development app I use that doesn't have a dark mode. >At > > night when the room is dark, its like a spotlight shining out of my >monitor. > > > > — > > You are receiving this because you commented. > > Reply to this email directly, view it on GitHub > > >< #368 (comment) >, > > or unsubscribe > > >< https://github.com/notifications/unsubscribe-auth/ABNITBBGHCIENYZ4NGSB2LLTLFMSXANCNFSM43WBCCLQ > > > . > > >— >You are receiving this because you authored the thread. >Reply to this email directly, view it on GitHub >< #368 (comment)>, >or unsubscribe >< https://github.com/notifications/unsubscribe-auth/AA5EK4WRGRACMJUF2K5XCNDTLFOEHANCNFSM43WBCCLQ >. > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#368 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABNITBALAC25C7OMXEA45OLTLFWF5ANCNFSM43WBCCLQ> .

frostius · 2021-04-29T19:11:06Z

Sometimes the size is persisted but never the location. Tested just now, and no persistence at all in 5 close/open cycles. I'm running Win10 on an external 4K monitor. The laptop screen is closed/disabled.

…

------ Original Message ------ From: "Jan Wilmans" ***@***.***> To: "CobaltFusion/DebugViewPP" ***@***.***> Cc: "Matt Frost" ***@***.***>; "Author" ***@***.***>

Sent: 4/29/2021 2:24:09 PM Subject: Re: [CobaltFusion/DebugViewPP] Dark theme (#368) I should already persist the screen location? doesn't it? On Thu, Apr 29, 2021, 16:44 Matt Frost ***@***.***> wrote: > For sure, theme persistence would be nice. On that note, persisting the > screen location/dimensions would be a nice-to-have as well. > > ------ Original Message ------ > From: "Jan Wilmans" ***@***.***> > To: "CobaltFusion/DebugViewPP" ***@***.***> > Cc: "Matt Frost" ***@***.***>; "Author" ***@***.***> > Sent: 4/29/2021 9:36:03 AM > Subject: Re: [CobaltFusion/DebugViewPP] Dark theme (#368) > > > > >good idea, I guess to work also need to persist this option? > > > >On Thu, Apr 29, 2021, 15:22 Matt Frost ***@***.***> wrote: > > > > > The ability to change the font color and log background would be a > >big > > > improvement if a true dark theme is not feasible. > > > > > > This is the only development app I use that doesn't have a dark mode. > >At > > > night when the room is dark, its like a spotlight shining out of my > >monitor. > > > > > > — > > > You are receiving this because you commented. > > > Reply to this email directly, view it on GitHub > > > > >< > #368 (comment) > >, > > > or unsubscribe > > > > >< > https://github.com/notifications/unsubscribe-auth/ABNITBBGHCIENYZ4NGSB2LLTLFMSXANCNFSM43WBCCLQ > > > > > . > > > > >— > >You are receiving this because you authored the thread. > >Reply to this email directly, view it on GitHub > >< > #368 (comment)>, > > >or unsubscribe > >< > https://github.com/notifications/unsubscribe-auth/AA5EK4WRGRACMJUF2K5XCNDTLFOEHANCNFSM43WBCCLQ > >. > > > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#368 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABNITBALAC25C7OMXEA45OLTLFWF5ANCNFSM43WBCCLQ> > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#368 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA5EK4SOATPC6URIO252WFTTLGP4TANCNFSM43WBCCLQ>.

janwilmans · 2021-04-29T23:03:11Z

I'm looking at this, because I remember there was a bug where the window could go/reopen at an off screen location if it was last closed with 2 monitors attached and reopened with only one. I not sure I can reliably detect this case.

…

On Thu, Apr 29, 2021, 21:11 Matt Frost ***@***.***> wrote: Sometimes the size is persisted but never the location. Tested just now, and no persistence at all in 5 close/open cycles. I'm running Win10 on an external 4K monitor. The laptop screen is closed/disabled. ------ Original Message ------ From: "Jan Wilmans" ***@***.***> To: "CobaltFusion/DebugViewPP" ***@***.***> Cc: "Matt Frost" ***@***.***>; "Author" ***@***.***> Sent: 4/29/2021 2:24:09 PM Subject: Re: [CobaltFusion/DebugViewPP] Dark theme (#368) > >I should already persist the screen location? doesn't it? > >On Thu, Apr 29, 2021, 16:44 Matt Frost ***@***.***> wrote: > > > For sure, theme persistence would be nice. On that note, persisting >the > > screen location/dimensions would be a nice-to-have as well. > > > > ------ Original Message ------ > > From: "Jan Wilmans" ***@***.***> > > To: "CobaltFusion/DebugViewPP" ***@***.***> > > Cc: "Matt Frost" ***@***.***>; "Author" ***@***.***> > > Sent: 4/29/2021 9:36:03 AM > > Subject: Re: [CobaltFusion/DebugViewPP] Dark theme (#368) > > > > > > > >good idea, I guess to work also need to persist this option? > > > > > >On Thu, Apr 29, 2021, 15:22 Matt Frost ***@***.***> wrote: > > > > > > > The ability to change the font color and log background would be >a > > >big > > > > improvement if a true dark theme is not feasible. > > > > > > > > This is the only development app I use that doesn't have a dark >mode. > > >At > > > > night when the room is dark, its like a spotlight shining out of >my > > >monitor. > > > > > > > > — > > > > You are receiving this because you commented. > > > > Reply to this email directly, view it on GitHub > > > > > > >< > > > #368 (comment) > > >, > > > > or unsubscribe > > > > > > >< > > > https://github.com/notifications/unsubscribe-auth/ABNITBBGHCIENYZ4NGSB2LLTLFMSXANCNFSM43WBCCLQ > > > > > > > . > > > > > > >— > > >You are receiving this because you authored the thread. > > >Reply to this email directly, view it on GitHub > > >< > > > #368 (comment) >, > > > > >or unsubscribe > > >< > > > https://github.com/notifications/unsubscribe-auth/AA5EK4WRGRACMJUF2K5XCNDTLFOEHANCNFSM43WBCCLQ > > >. > > > > > > > — > > You are receiving this because you commented. > > Reply to this email directly, view it on GitHub > > >< #368 (comment) >, > > or unsubscribe > > >< https://github.com/notifications/unsubscribe-auth/ABNITBALAC25C7OMXEA45OLTLFWF5ANCNFSM43WBCCLQ > > > . > > >— >You are receiving this because you authored the thread. >Reply to this email directly, view it on GitHub >< #368 (comment)>, >or unsubscribe >< https://github.com/notifications/unsubscribe-auth/AA5EK4SOATPC6URIO252WFTTLGP4TANCNFSM43WBCCLQ >. > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#368 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABNITBHZYC3XC4V7JF2UG3TTLGVODANCNFSM43WBCCLQ> .

frostius · 2021-04-29T23:45:33Z

This is not that case. I'm just opening and closing on a single monitor. Send me a debug version and I'd be happy to post the log.

…

On Thu, Apr 29, 2021, 7:03 PM Jan Wilmans ***@***.***> wrote: I'm looking at this, because I remember there was a bug where the window could go/reopen at an off screen location if it was last closed with 2 monitors attached and reopened with only one. I not sure I can reliably detect this case. On Thu, Apr 29, 2021, 21:11 Matt Frost ***@***.***> wrote: > Sometimes the size is persisted but never the location. > Tested just now, and no persistence at all in 5 close/open cycles. > > I'm running Win10 on an external 4K monitor. The laptop screen is > closed/disabled. > > ------ Original Message ------ > From: "Jan Wilmans" ***@***.***> > To: "CobaltFusion/DebugViewPP" ***@***.***> > Cc: "Matt Frost" ***@***.***>; "Author" ***@***.***> > Sent: 4/29/2021 2:24:09 PM > Subject: Re: [CobaltFusion/DebugViewPP] Dark theme (#368) > > > > >I should already persist the screen location? doesn't it? > > > >On Thu, Apr 29, 2021, 16:44 Matt Frost ***@***.***> wrote: > > > > > For sure, theme persistence would be nice. On that note, persisting > >the > > > screen location/dimensions would be a nice-to-have as well. > > > > > > ------ Original Message ------ > > > From: "Jan Wilmans" ***@***.***> > > > To: "CobaltFusion/DebugViewPP" ***@***.***> > > > Cc: "Matt Frost" ***@***.***>; "Author" ***@***.***> > > > Sent: 4/29/2021 9:36:03 AM > > > Subject: Re: [CobaltFusion/DebugViewPP] Dark theme (#368) > > > > > > > > > > >good idea, I guess to work also need to persist this option? > > > > > > > >On Thu, Apr 29, 2021, 15:22 Matt Frost ***@***.***> wrote: > > > > > > > > > The ability to change the font color and log background would be > >a > > > >big > > > > > improvement if a true dark theme is not feasible. > > > > > > > > > > This is the only development app I use that doesn't have a dark > >mode. > > > >At > > > > > night when the room is dark, its like a spotlight shining out of > >my > > > >monitor. > > > > > > > > > > — > > > > > You are receiving this because you commented. > > > > > Reply to this email directly, view it on GitHub > > > > > > > > >< > > > > > > #368 (comment) > > > >, > > > > > or unsubscribe > > > > > > > > >< > > > > > > https://github.com/notifications/unsubscribe-auth/ABNITBBGHCIENYZ4NGSB2LLTLFMSXANCNFSM43WBCCLQ > > > > > > > > > . > > > > > > > > >— > > > >You are receiving this because you authored the thread. > > > >Reply to this email directly, view it on GitHub > > > >< > > > > > > #368 (comment) > >, > > > > > > >or unsubscribe > > > >< > > > > > > https://github.com/notifications/unsubscribe-auth/AA5EK4WRGRACMJUF2K5XCNDTLFOEHANCNFSM43WBCCLQ > > > >. > > > > > > > > > > — > > > You are receiving this because you commented. > > > Reply to this email directly, view it on GitHub > > > > >< > #368 (comment) > >, > > > or unsubscribe > > > > >< > https://github.com/notifications/unsubscribe-auth/ABNITBALAC25C7OMXEA45OLTLFWF5ANCNFSM43WBCCLQ > > > > > . > > > > >— > >You are receiving this because you authored the thread. > >Reply to this email directly, view it on GitHub > >< > #368 (comment) >, > > >or unsubscribe > >< > https://github.com/notifications/unsubscribe-auth/AA5EK4SOATPC6URIO252WFTTLGP4TANCNFSM43WBCCLQ > >. > > > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > < #368 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/ABNITBHZYC3XC4V7JF2UG3TTLGVODANCNFSM43WBCCLQ > > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#368 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA5EK4SSO2VV64S4ZT5FWK3TLHQT7ANCNFSM43WBCCLQ> .

janwilmans · 2021-04-30T18:09:17Z

I just tested this, but the latest version https://github.com/CobaltFusion/DebugViewPP/releases restores the position correctly here, even over different monitors, it shows back up at the correct position, on the same monitor I used it on.

Can you send me a screenshot of the 'about' window of your debugview++ ?

Mabus13 · 2021-05-11T12:01:23Z

Any new version with dark theme soon?

janwilmans · 2021-05-11T13:43:33Z

I have more pressing work planned, so unless I get a pull request, not any time soon...

Mabus13 · 2021-05-11T14:49:16Z

Pity. Wish you easy coding and more free time. ^___^

smallscript · 2021-05-24T21:57:43Z

🦜 I'd love it as well ^__^

Anyone have some notes or a summary of areas to look at in the code-base?

Mabus13 · 2021-05-25T06:30:28Z

🦜 I'd love it as well ^__^

Anyone have some notes or a summary of areas to look at in the code-base?

LRESULT CMainFrame::OnCreate(const CREATESTRUCT* /pCreate/) in MainFrame.cpp i looked here but also have not time to finish that feature...

janwilmans added enhancement User request help wanted labels Dec 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dark theme #368

Dark theme #368

frostius commented Apr 28, 2021

Mabus13 commented Apr 28, 2021

janwilmans commented Apr 28, 2021

frostius commented Apr 29, 2021

janwilmans commented Apr 29, 2021 via email

frostius commented Apr 29, 2021 via email

janwilmans commented Apr 29, 2021 via email

frostius commented Apr 29, 2021 via email

janwilmans commented Apr 29, 2021 via email

frostius commented Apr 29, 2021 via email

janwilmans commented Apr 30, 2021

Mabus13 commented May 11, 2021

janwilmans commented May 11, 2021

Mabus13 commented May 11, 2021

smallscript commented May 24, 2021 •

edited

Mabus13 commented May 25, 2021 •

edited

Dark theme #368

Dark theme #368

Comments

frostius commented Apr 28, 2021

Mabus13 commented Apr 28, 2021

janwilmans commented Apr 28, 2021

frostius commented Apr 29, 2021

janwilmans commented Apr 29, 2021 via email

frostius commented Apr 29, 2021 via email

janwilmans commented Apr 29, 2021 via email

frostius commented Apr 29, 2021 via email

janwilmans commented Apr 29, 2021 via email

frostius commented Apr 29, 2021 via email

janwilmans commented Apr 30, 2021

Mabus13 commented May 11, 2021

janwilmans commented May 11, 2021

Mabus13 commented May 11, 2021

smallscript commented May 24, 2021 • edited

Mabus13 commented May 25, 2021 • edited

smallscript commented May 24, 2021 •

edited

Mabus13 commented May 25, 2021 •

edited