module loading improvements #1302
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#1301
Also there is no cyclic dependency detection (not included in issue)
Modification
Rewrote
DefaultModuleProvider#loadAll()to respect dependenciesChanged methods in
ModuleDependencyUtilto useModuleConfigurationrather thanModuleWrapperto allow using the methods without instantiating any classes of the moduleModified tests to work again after changes to
ModuleDependencyUtilAdded an exception for cyclic dependencies.
I haven't added a test for cyclic dependency detection, because there wasn't a nice way to do so
Result
Fixes modules being loaded onto the classpath before their dependency modules are loaded.
There is now a cyclic dependency detection.
Other context
Fixes #1301
I tested the PR with my demo project (master and cyclic branch).