Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#148 added support for other partitions (govcloud, iso, isob, cn) #163

Merged
merged 1 commit into from
Nov 20, 2020
Merged

#148 added support for other partitions (govcloud, iso, isob, cn) #163

merged 1 commit into from
Nov 20, 2020

Conversation

meshuga
Copy link
Member

@meshuga meshuga commented Nov 19, 2020

closes #148

leandrodamascena
leandrodamascena approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved!

I'll open another PR to improve the message error when you're using a non-default AWS partition.

@leandrodamascena leandrodamascena merged commit 8f3d89e into develop Nov 20, 2020
@leandrodamascena leandrodamascena deleted the partitions_support branch November 23, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrodamascena leandrodamascena leandrodamascena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failures when trying against a us-gov based region
2 participants
@meshuga @leandrodamascena