Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch-crafting should not receive penalty for cumbersome crafting when single craft doesn`t have the penalty. #73936

Open
Void-Seeker opened this issue May 19, 2024 · 3 comments
Labels
<Suggestion / Discussion> Talk it out before implementing

Comments

@Void-Seeker
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Let's say, we are crafting planks from logs using table saw. When we schedule single craft, it finishes fast and without penalties. But if we batch 20 crafts, crafting speed goes to nothing, and we have messages The in progress plank is too large and/or heavy to work on comfortably. You are working slowly. That really makes a little sense, as batch crafting in this case is supposed to craft items in series, and if single craft is fine, why batch gets the penalty?

Solution you would like.

Batch-crafting should not receive penalty for cumbersome crafting when single craft doesn`t have the penalty.

Describe alternatives you have considered.

I can just spam "Recraft last recipe" key, I suppose...

Additional context

No response

@Void-Seeker Void-Seeker added the <Suggestion / Discussion> Talk it out before implementing label May 19, 2024
@PatrikLundell
Copy link
Contributor

Well, there are different flavors of batch crafting. While plank crafting is sequential, several other kinds just result in more ingredients being used (many kinds of food production, for example: make more soup in a single go).

@natsirt721
Copy link
Contributor

natsirt721 commented May 22, 2024

There's already a batch crafting speed bonus - that should be able to account for 'many serial' vs 'batch parallelizable'. What is the rationale behind the 'craft too big' speed penalty?

e: why isn't the "this thing is large and that makes it more difficult to make" time cost just baked directly into the crafting time for the recipe?

@PatrikLundell
Copy link
Contributor

I don't think there's been a decision to make large batches bulky, but rather a result of the bulky item code not having any code to treat batches differently from single crafts.

I don't think the calculation of bulky item is static, but rather depending on a bunch of factors, such as whether you're trying to handle the craft in your hands or on a surface of various qualities, and might also include character strength. Note that these are guesses, as I haven't looked at the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

3 participants