Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect --help text about gruvbox #1340

Closed
1 task done
ShalokShalom opened this issue Nov 29, 2023 · 2 comments
Closed
1 task done

Incorrect --help text about gruvbox #1340

ShalokShalom opened this issue Nov 29, 2023 · 2 comments
Labels
bug Something isn't working the way that is expected.

Comments

@ShalokShalom
Copy link

Checklist

What operating system and version are you using?

NixOS

What architecture are you using?

x86_64 / AMD64

What terminal(s) are you running bottom on?

Konsole

Are you using ZFS?

No

What version of bottom are you running?

0.9.1

How did you install bottom?

NixOS repos

Describe the issue

The help text for the gruvbox theme says its a light theme.

What is the expected behaviour?

Text says dark theme

What is the actual behaviour?

Screenshot_20231129_221139

How can we reproduce this?

btm --help

Additional information

Have a good day 👍🏻

(Curious: Why do you ask, if someone has ZFS as their file system? How is that relevant?)

@ShalokShalom ShalokShalom added the bug Something isn't working the way that is expected. label Nov 29, 2023
@ClementTsang
Copy link
Owner

ClementTsang commented Nov 29, 2023

If I'm understanding you correctly, the issue is around the description for the gruvbox entry?

If so, the description was mostly copy-pasted from gruvbox's own description:

Designed as a bright theme with pastel 'retro groove' colors and light/dark mode switching in the way of solarized. The main focus when developing gruvbox is to keep colors easily distinguishable, contrast enough and still pleasant for the eyes.

I don't really think this is an issue and it's definitely not a bug, but I can remove the word "bright" if people think that's confusing.


As for why do I ask for ZFS, it's because of #1297, which was caused by someone using ZFS. I might change that to just ask for file system type in general.

@ShalokShalom
Copy link
Author

ShalokShalom commented Nov 30, 2023

I don't really think this is an issue and it's definitely not a bug, but I can remove the word "bright" if people think that's confusing.

Forget what I said. I forgot for a second, that may dark Terminal background is unaffected by your theme. My mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working the way that is expected.
Projects
None yet
Development

No branches or pull requests

2 participants