Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SMART temperature support for some disks #1228

Open
1 task done
dtcyganok opened this issue Jun 26, 2023 · 10 comments
Open
1 task done

Add SMART temperature support for some disks #1228

dtcyganok opened this issue Jun 26, 2023 · 10 comments
Labels
feature Requests for a new feature.

Comments

@dtcyganok
Copy link

dtcyganok commented Jun 26, 2023

Checklist

What operating system and version are you using?

Arch Linux (kernel 6.3.9)

What architecture are you using?

x86_64 / AMD64

What terminal(s) are you running bottom on?

kitty 0.28.1

What version of bottom are you running?

0.9.3

How did you install bottom?

Arch Linux official repos

Describe the issue

I have 3 disks and none of them show up in temperature widget

What is the expected behaviour?

All disks are displayed in the temperature widget

What is the actual behaviour?

See the description

How can we reproduce this?

It's an interesting question. I have no idea what causes that behavior

Additional information

There is no problem with sensors. The disks' temperatures are available via SMART

@dtcyganok dtcyganok added the bug Something isn't working the way that is expected. label Jun 26, 2023
@ClementTsang
Copy link
Owner

Just to make sure, do these disks show up if you run sensors?

@ClementTsang
Copy link
Owner

Will also be helpful if you can send a screenshot of what you're seeing.

@dtcyganok
Copy link
Author

Thanks for your answer! My disks aren't showing up with sensors...
Does it mean the bug is in my system?

@ClementTsang
Copy link
Owner

ClementTsang commented Jun 26, 2023

Not sure but I don't think so... However, bottom currently won't be able to see that temperature sensor (so it isn't a bug on bottom's side), since we pull from that source of data for Linux.

That said, it would be interesting to see if I can replicate + get it to work... I have some potential ideas. I might change this issue into a feature request instead.

@dtcyganok
Copy link
Author

Do you still need a screenshot?

@ClementTsang
Copy link
Owner

Would be appreciated just so I know what you're seeing in case there's some detail I'm missing!

@ClementTsang ClementTsang added feature Requests for a new feature. and removed bug Something isn't working the way that is expected. labels Jun 26, 2023
@dtcyganok
Copy link
Author

No problem)
Screenshot from 2023-06-26 23-52-12

@ClementTsang
Copy link
Owner

Thanks! One other question - would you happen to know the brand/models of the SSD/HDDs you are using? Just curious what models might be causing the situation where we might have to fall back to reading SMART data.

@dtcyganok
Copy link
Author

I have:

KINGSTON SVP200S37A120G (507KC4)
ST1000DM010-2EP102 (CC43)
ST3250410AS (3.AAA)

@dtcyganok
Copy link
Author

dtcyganok commented Jun 26, 2023

I've tried to regenerate a list of kernel modules using sensors-detect, but it had no effect.
Seems the getting the disk temperature via SMART is a more reliable solution...

@ClementTsang ClementTsang changed the title Disk temperature (ssd/hdd) not showing Some disk temperatures can only be found using SMART Jun 28, 2023
@ClementTsang ClementTsang changed the title Some disk temperatures can only be found using SMART Add SMART temperature support for some disks Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Requests for a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants