Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for finer control over legend position/type #1125

Open
1 task done
ClementTsang opened this issue May 4, 2023 · 9 comments
Open
1 task done

Allow for finer control over legend position/type #1125

ClementTsang opened this issue May 4, 2023 · 9 comments
Labels
feature Requests for a new feature.

Comments

@ClementTsang
Copy link
Owner

ClementTsang commented May 4, 2023

Checklist

Describe the feature request

For all time graphs, it would be nice to be able to have finer-grain control over how the legend is displayed (e.g. which side it appears, the type, like whether it's like the CPU one or normal ones, hiding it, etc).

@ClementTsang ClementTsang added the feature Requests for a new feature. label May 4, 2023
@ClementTsang ClementTsang mentioned this issue May 4, 2023
1 task
@RobertoMaurizzi
Copy link

RobertoMaurizzi commented Sep 21, 2023

It would be useful to have the memory and network charts legends on the left too, maybe even by default, since right now it often happens you don't see anything until a few minutes after it happened because the chart lines are hidden by the legend.

@JustCauseWhyNot
Copy link

I'll add my request here since it seems more appropriate here than in a separate issue. I'd be nice to have an option to choose to show either the box of info in mem/net, over using the graph. Especially so if using a tiling wm such as I, and you've got a lot of windows open. That way when the window for btm gets shrunk I'd see the number like this
2023-11-23_12-48 rather than just seeing a graph which isn't all the useful when in small window.

@lyuha
Copy link
Contributor

lyuha commented Dec 25, 2023

I completely agree this comment. So I make available that the chart can have a left legend at ratatui v0.25(ratatui-org/ratatui#378).

It would be useful to have the memory and network charts legends on the left too, maybe even by default, since right now it often happen you don't see anything until a few minutes after it happens because the chart lines are hidden by the legend.

@lyuha
Copy link
Contributor

lyuha commented Jan 4, 2024

I tested that chart draw a legend on left side. How about it?

Preview Images

image
image

@RobertoMaurizzi
Copy link

I'd say it's definitely more useful, thanks @lyuha!

@lyuha
Copy link
Contributor

lyuha commented Feb 21, 2024

I read the refactoring commit(77777ef).
Now the TimeChart has an option to configure it's legend position. However, Bottom doesn't have any config option about a legend position.

Is there any plan about this?
Add options like cpu's left_side in config file, add key layout section in config? or have any other?

@ClementTsang
Copy link
Owner Author

Yep, was planning on adding this at some point.

@lyuha
Copy link
Contributor

lyuha commented Feb 21, 2024

Is there anything that I help this work?

@ClementTsang
Copy link
Owner Author

If you want you can try to make a PR, but it's mostly figuring out how the config/arg option would look really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Requests for a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants