Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update codebase to reflect the latest configuration in the parent open-sdg-data project #45

Merged
merged 12 commits into from
Mar 12, 2024

Conversation

jaylenw
Copy link
Member

@jaylenw jaylenw commented Mar 6, 2024

What does this PR do?

Background info

How can this be tested (manually and/or automated test)?

Provide manual tests steps if applicable

Setup the local development environment as documented in the README.md. Run the the commands for verifying and building the site.

Provide steps for running automated tests if applicable

N/A

Which issue(s) is/are related to this PR?

This PR is/are related to issue(s) #42 and #44

close #42
close #44
close #41
close #43

…e8cf8344d5f130d99,

of the open-sdg-data-starter repository

close #44
…ironment

along with building the data site

close #44
commit e8ec7c1
Author: Robert Villarreal <[email protected]>
Date:   Thu Feb 22 17:29:27 2024 -0800

    update variable name for cloudfront distribution id

commit 91064b0
Author: Robert Villarreal <[email protected]>
Date:   Thu Feb 22 17:09:00 2024 -0800

    update the branch name to development, revert changes to requirements.txy

commit 4a7979d
Author: Robert Villarreal <[email protected]>
Date:   Thu Feb 22 16:59:14 2024 -0800

    resolve deprecations, update to use role instead of access keys in dev and prod deployments

commit 9d4f469
Author: Robert Villarreal <[email protected]>
Date:   Tue May 16 16:51:02 2023 -0700

    revert the changes of sdg-build requirement version

commit 9781e9b
Author: Robert Villarreal <[email protected]>
Date:   Tue May 16 16:42:15 2023 -0700

    test latest version

commit 1035fef
Author: Robert Villarreal <[email protected]>
Date:   Tue May 16 16:37:26 2023 -0700

    update sdg-build dependency

commit c03965d
Author: Robert Villarreal <[email protected]>
Date:   Tue May 16 16:35:40 2023 -0700

    revert python checkout to v1

commit ee6aef2
Author: Robert Villarreal <[email protected]>
Date:   Tue May 16 16:28:36 2023 -0700

    update requirements repo format

commit a54ed27
Author: Robert Villarreal <[email protected]>
Date:   Tue May 16 16:25:34 2023 -0700

    use https on github requirements

commit bff6089
Author: Robert Villarreal <[email protected]>
Date:   Tue May 16 16:18:29 2023 -0700

    add pat username

commit a79beb4
Author: Robert Villarreal <[email protected]>
Date:   Tue May 16 16:09:45 2023 -0700

    test-update branch and test on temp site starter branch

commit fd158f3
Author: Robert Villarreal <[email protected]>
Date:   Tue May 16 16:08:15 2023 -0700

    update deploy to use new tokens, test on current branch

commit bb1c77a
Author: Robert Villarreal <[email protected]>
Date:   Tue May 16 08:46:24 2023 -0700

    resolve deprecations and add environments for dev and prod deployments

merge ghi-42 branch into ghi-44 branch
close #42
version 3.11 and include the running of the check
data script

close #42
close #44
for all branches. configure workflows to upload to
development environment and production environment
for their respective branches.

close #44
@jaylenw jaylenw added the enhancement New feature or request label Mar 6, 2024
@jaylenw jaylenw requested review from naomiikd, kerrylacity and a team March 6, 2024 00:52
@jaylenw jaylenw self-assigned this Mar 6, 2024
RV-LACity
RV-LACity previously approved these changes Mar 6, 2024
naomiikd
naomiikd previously approved these changes Mar 6, 2024
@jaylenw
Copy link
Member Author

jaylenw commented Mar 6, 2024

@naomiikd @kerrylacity , a part of the approval process, please make sure the instructions for setting up the local dev environment and running the commands I've documented works for you two 😄 . Let me know if it doesn't and we can see if I need to update the documentation.

@jaylenw jaylenw changed the title feat: update codebase to reflect the latest configuration in the parent opn-sdg-data project feat: update codebase to reflect the latest configuration in the parent open-sdg-data project Mar 6, 2024
@naomiikd naomiikd self-requested a review March 6, 2024 01:14
when the microsoft store is disabled. clarify
docker instructions

close #44
@jaylenw jaylenw dismissed stale reviews from naomiikd and RV-LACity via 0480ca0 March 7, 2024 00:16
@jaylenw
Copy link
Member Author

jaylenw commented Mar 7, 2024

@naomiikd let me know if these changes are good, see 0480ca0

@naomiikd
Copy link
Collaborator

naomiikd commented Mar 7, 2024

@jaylenw Those changes look perfect! Thank you.

naomiikd
naomiikd previously approved these changes Mar 7, 2024
reflect the new 2.3.0 release for open-sdg

close #44
@jaylenw
Copy link
Member Author

jaylenw commented Mar 8, 2024

@RV-LACity @naomiikd @kerrylacity , by working on the sdg-site-starter repo, I have updated the requirements.txt and config setting for translations as mentioned in https://github.com/open-sdg/open-sdg/releases/tag/2.3.0. Reviews have been requested again.

@jaylenw
Copy link
Member Author

jaylenw commented Mar 11, 2024

Updated PR description to close #41 & close #43

@jaylenw jaylenw merged commit df21c1d into development Mar 12, 2024
4 checks passed
@ita-devops-release-manager ita-devops-release-manager bot added the staged PRs that have been merged into the development branch containing changes yet to be pushed to prod label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request staged PRs that have been merged into the development branch containing changes yet to be pushed to prod
Projects
None yet
4 participants