-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Csv to Parquet - Nullable types #314
Comments
Pls raise PR. will look into it. thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello!
First off, great library and very useful for my use-case of converting csv to parquet files. Thanks for all the work you put into this!
I'm currently facing one problem though and hope you can help me out:
The primitives in my parquet files need to be Nullable. I registered this delegate:
This works as expected. The problem is, that type string is then assigned to these Nullable types:
ChoETL/src/ChoETL.Parquet/ChoParquetRecordWriter.cs
Lines 253 to 254 in 566eea2
Is there a specific reason for this choice, or is there another way to enable Nullables for the Parquet writer?
(A small change in the RecordWriter code fixes this issue for me. I'll gladly create a PR if this is considered a bug and not a design choice 😉)
Thanks for your time!
The text was updated successfully, but these errors were encountered: