Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore URL-based search functionality #160

Open
mathiasbynens opened this issue Sep 8, 2020 · 1 comment
Open

Restore URL-based search functionality #160

mathiasbynens opened this issue Sep 8, 2020 · 1 comment

Comments

@mathiasbynens
Copy link
Member

One feature that got lost in the rewrite is the ability to permalink search result pages. This also enabled easy searching from within the Chrome address bar (by adding the site as a custom search engine). Let’s restore this functionality!

In terms of URL design, this could be done with a query parameter:

https://chromedevtools.github.io/devtools-protocol/?q=foo

…or with a hash:

https://chromedevtools.github.io/devtools-protocol/#q=foo
@TimvdLippe
Copy link
Contributor

The first version probably is the best option, as we already use the URL hash for scrolling to the correct location. +1 for restoring this functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants