Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated logic leading to message quirk #292

Open
ms5984 opened this issue Sep 9, 2022 · 2 comments · May be fixed by #293
Open

Repeated logic leading to message quirk #292

ms5984 opened this issue Sep 9, 2022 · 2 comments · May be fixed by #293

Comments

@ms5984
Copy link

ms5984 commented Sep 9, 2022

owo-bot-bug-report-sane
I have traced this back to crate.js#openCrate and lootbox.js#openMultiple, wherein the latter does not take the opportunity to consolidate common logic and/or simply delegate to the existing #openBox method (which is currently used only on execute of no-args!). I haven't done much js but I'd like to try either 1) writing conditional message code or 2) refactoring lootbox.js execute to more closely resemble crate.js execute and deduplicate common code in the process 🙂

@Caviarbro
Copy link
Contributor

Just a side note if you want to censor your name don't forget to censor the weapon id as well LOL! 😆

@ms5984
Copy link
Author

ms5984 commented Sep 9, 2022

Noted :P

@ms5984 ms5984 linked a pull request Sep 10, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants