-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repeated logic leading to message quirk #292
Comments
Just a side note if you want to censor your name don't forget to censor the weapon id as well LOL! 😆 |
Noted :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have traced this back to crate.js
#openCrate
and lootbox.js#openMultiple
, wherein the latter does not take the opportunity to consolidate common logic and/or simply delegate to the existing#openBox
method (which is currently used only on execute of no-args!). I haven't done much js but I'd like to try either 1) writing conditional message code or 2) refactoringlootbox.js
execute to more closely resemblecrate.js
execute and deduplicate common code in the process 🙂The text was updated successfully, but these errors were encountered: