Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reqwest-middleware 0.3.0 #21

Open
lededje opened this issue Apr 21, 2024 · 1 comment · May be fixed by #22
Open

Add support for reqwest-middleware 0.3.0 #21

lededje opened this issue Apr 21, 2024 · 1 comment · May be fixed by #22

Comments

@lededje
Copy link

lededje commented Apr 21, 2024

Reqwest updated to 0.12 recently and their implementation of reqwest changed. This required reqwest middleware to update it's implementation which in turn made rvcr incompatible with it's most recent version.

Please can we update reqwest middleware to 0.3

@lededje
Copy link
Author

lededje commented Apr 21, 2024

The updates I made are as follows:

reqwest = { version = "0.12.4" }
reqwest-middleware = "0.3.0"
http = "1.0.0"

There is still a lifetime issue on the handle method for impl Middleware that I'm unable to resolve.

This looked to be a change in the struct that now references a different argument type.

lededje added a commit to lededje/rvcr that referenced this issue Apr 21, 2024
@lededje lededje linked a pull request Apr 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant