Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure client don't cache plugin translations file #6397

Open
kontrollanten opened this issue May 13, 2024 · 0 comments
Open

Ensure client don't cache plugin translations file #6397

kontrollanten opened this issue May 13, 2024 · 0 comments
Labels
Component: PeerTube Plugin 📦 Features that can be developed in a plugin, but require PeerTube plugin API development Type: Feature Request ✨

Comments

@kontrollanten
Copy link
Contributor

Describe the problem to be solved

Currently plugin translations are served from /plugins/translations/{locale}.json There's no Cache-Control header nor content hash in the URL, which may cause clients to unexpectedly cache the file with stale content.

Describe the solution you would like

Since translations are always loaded they can be served direct with the HTML file. If that's not possible, add a content hash to the URL and set Cache-control max-age to one year.

@Chocobozzz Chocobozzz added Type: Feature Request ✨ Component: PeerTube Plugin 📦 Features that can be developed in a plugin, but require PeerTube plugin API development labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PeerTube Plugin 📦 Features that can be developed in a plugin, but require PeerTube plugin API development Type: Feature Request ✨
Projects
None yet
Development

No branches or pull requests

2 participants