Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change unit test #137

Open
tomschenkjr opened this issue Mar 28, 2017 · 6 comments
Open

Change unit test #137

tomschenkjr opened this issue Mar 28, 2017 · 6 comments
Assignees
Milestone

Comments

@tomschenkjr
Copy link
Contributor

We've been using @CityOfBoston open data portal to run a unit test to ensure the package is correctly importing data with missing dates (from #27). However, in recent tests, it appears that data set is no longer available--at least, need to login to see it.

The original data set was the Mayor's 24-hour hotline dataset. However, Boston is moving to a new data portal and is likely migrating content. @therriault was the above data set replaced by the same data from the new portal?

Regardless, for us, Boston is moving to a whole new portal that is not Socrata based. We will need to replace the test. We need to find or create (see #45) a new data set with a missing date to test this functionality.

(Discovered this while working on #136)

@tomschenkjr
Copy link
Contributor Author

Turns out this issue was related to a technical glitch for Boston and is working again. Not a pressing issue but their portal will be retired soon so keeping it open for now.

@therriault - is this data set being immediately retired with the new data portal on the 6th?

@therriault
Copy link

We moved the dataset to the new portal: https://data.boston.gov/dataset/mayors-24-hour-hotline. But the old site will be up for a few months still.

@tomschenkjr
Copy link
Contributor Author

@chrismetcalf - Boston has redirected their old portal data to their new portal, which broke a unit test for a specific case where the first entry is a missing date.

Would it be acceptable to upload a similar data set to soda.demo.socrata.com so we can keep the unit test? I hesitate to put it on Chicago's because it mixes a technical, not-otherwise-useful data with official city data.

@tomschenkjr tomschenkjr added this to the 1.7.4 milestone Dec 4, 2017
tomschenkjr pushed a commit that referenced this issue Dec 11, 2017
This test should only be temporarially ignored until a better solution (which does not compromise code coverage) is derived.
@tomschenkjr
Copy link
Contributor Author

Right now, have staged a temporary fix that just ignores the unit test on branch hotfix1.7.4

@tomschenkjr tomschenkjr mentioned this issue Dec 11, 2017
@chrismetcalf
Copy link

@tomschenkjr I relayed a recommendation to you through our support team, but I thought I'd post it here too:

How I handle authenticated integration tests for the other libraries is to pull in the email/password details from an environment variable I can set before running the test. Then I create a continuous integration setup in Travis CI that automatically tests pushes to GitHub, and I can set hidden environment variables for a very-limited test user in their interface so Travis can run the tests. Ex: https://travis-ci.org/socrata/soda-php

Then you can set the environment variables locally if you want to test locally, and you can rely on TravisCI to make sure you don't merge bad changes from others.

tomschenkjr added a commit that referenced this issue Dec 12, 2017
Based on feedback from @geneorama, have included the `httr::` prefix to all `user_agent()` calls.

Added clarifying comments related to #137 so our future-selves can be reminded of turning on the test again.
@tomschenkjr
Copy link
Contributor Author

Actually, will re-open this since we only have a temporary fix in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants