You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The method OffLatticeRandomFieldGenerator::SampleRandomField was not being called directly in a test, and on further inspection rand() was being called:
A double was expected, and this caused that function to return nonsense.
I am putting in a temporary fix as part of #233, but I think the code needs properly looking over.
It is currently only tested in a "same as yesterday" manner, and it would be useful to verify some statistical properties of the noise (addressed in f23ec4a; see Utilise larger GitHub hosted runners #233)
The structure std::array<double, 3> is used as a corner point, and it may be more idiomatic to use a ChastePoint
I would like to understand how the time lengthscale interacts with the space lengthscale
Periodicity functionality is implied, but doesn't appear to exist.
The text was updated successfully, but these errors were encountered:
The recent coverage failures appear genuine.
The method
OffLatticeRandomFieldGenerator::SampleRandomField
was not being called directly in a test, and on further inspectionrand()
was being called:Chaste/mesh/src/random_field/OffLatticeRandomFieldGenerator.cpp
Line 104 in b98110e
A double was expected, and this caused that function to return nonsense.
I am putting in a temporary fix as part of #233, but I think the code needs properly looking over.
It is currently only tested in a "same as yesterday" manner, and it would be useful to verify some statistical properties of the noise(addressed in f23ec4a; see Utilise larger GitHub hosted runners #233)std::array<double, 3>
is used as a corner point, and it may be more idiomatic to use aChastePoint
The text was updated successfully, but these errors were encountered: