Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look over random field generator code #234

Open
fcooper8472 opened this issue Mar 4, 2024 · 0 comments
Open

Look over random field generator code #234

fcooper8472 opened this issue Mar 4, 2024 · 0 comments

Comments

@fcooper8472
Copy link
Member

fcooper8472 commented Mar 4, 2024

The recent coverage failures appear genuine.

The method OffLatticeRandomFieldGenerator::SampleRandomField was not being called directly in a test, and on further inspection rand() was being called:

return this->SampleRandomFieldAtTime(rNodes, rand());

A double was expected, and this caused that function to return nonsense.

I am putting in a temporary fix as part of #233, but I think the code needs properly looking over.

  1. It is currently only tested in a "same as yesterday" manner, and it would be useful to verify some statistical properties of the noise (addressed in f23ec4a; see Utilise larger GitHub hosted runners #233)
  2. The structure std::array<double, 3> is used as a corner point, and it may be more idiomatic to use a ChastePoint
  3. I would like to understand how the time lengthscale interacts with the space lengthscale
  4. Periodicity functionality is implied, but doesn't appear to exist.
@fcooper8472 fcooper8472 self-assigned this Mar 4, 2024
fcooper8472 added a commit that referenced this issue Mar 4, 2024
See #234 for longer-term solution
@AlexFletcher AlexFletcher added this to the BBR milestone 1.1 milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants