Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [Hang] Regal recipe hangs the app if there is a chaos recipe item found close in the tab #616

Open
vault101 opened this issue Apr 20, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@vault101
Copy link

vault101 commented Apr 20, 2024

Prerequisites

Please answer the following questions for yourself before submitting an issue.

  • [y ] I am running the latest release (not a beta / pre-release)
  • [y ] I checked the FAQ and found no common resolution for my issue
  • [y ] I checked to make sure that this issue has not already been filed (by doing a quick search in the issue tracker)

Expected Behavior

Regal recipe works

Current Behavior

If check Regal recipe and there is a chao recipe item in the tab, the app hangs.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Check Regal recipe, there is a chaos item in the tab
  2. in GenerateItemSets_Greedy, in the while true loop, closestMissingItem will be the chaos item mentioned, so it won't fill the recipe, nor will it break out of the loop
  3. the app hangs

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

  • Chaos Recipe Enhancer Version: tag: 3.24.3001
  • Operating System: Windows 10
  • Chaos Recipe Enhancer Settings (XML file or screenshot will suffice):
<setting name="ChaosRecipeTrackingEnabled" serializeAs="String">
                <value>False</value>
            </setting>
            <setting name="LeagueName" serializeAs="String">
                <value>Necropolis</value>
            </setting>
            <setting name="StashTabIndices" serializeAs="String">
                <value>2</value>
            </setting>

Still figuring out the code so can't make a pull request, sry

@vault101 vault101 added the bug Something isn't working label Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant