Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post processing HTML python script #45

Merged
merged 2 commits into from
May 25, 2023
Merged

Post processing HTML python script #45

merged 2 commits into from
May 25, 2023

Conversation

andreidev1
Copy link
Contributor

@andreidev1 andreidev1 commented May 25, 2023

partially fixes #35

@mario4tier mario4tier merged commit 631bfe4 into ChainMovers:main May 25, 2023
2 checks passed
@mario4tier
Copy link
Member

Thanks. Worked well.

Some feedback (I imagine you were probably already considering some of these since this was a quick first iteration/partial commit!):

(1) Please sort in reverse order (the one with most contribution should be first)

(2) In comments on top, please add instruction to start a static browser on ~/suibase/docs/src/.vuepress/dist (something I will forget 6 months from now).

(3) Consider making "grep -ril contributors" tighter.
e.g. mermaid.core-0f834940.js should not be in the list
Adding a bit more regex helps:
grep -ril "const.*JSON.*git.*contributors"

(4) "const e" vs "const t"
Is there a way to make this work without caring if e or t (who knows... could be a different letter used in slightly different scenario!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Duplicated cookbook contributors
2 participants