Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate version-specific validation steps #244

Open
javagl opened this issue Nov 29, 2022 · 1 comment
Open

Investigate version-specific validation steps #244

javagl opened this issue Nov 29, 2022 · 1 comment

Comments

@javagl
Copy link
Contributor

javagl commented Nov 29, 2022

The current implementation of the validator is focussed on 3D Tiles 1.1. As suggested by the semantic versioning, version 1.1 mainly consisted of additions to the existing standard, and these additional elements are covered in the validation. Beyond that, the asset.version is largely ignored. Additional checks should be added that take these version-specific differences into account. This means that certain elements (like implicit tilesets) are not valid in a 3D Tiles 1.0 tileset, and a tileset that has an asset.version of 1.0 but contains implicit tiling information should be considered to be invalid.

This is related to #231 , which specifically refers to the question of which extensions are allowed or expected in certain tileset versions.

@javagl
Copy link
Contributor Author

javagl commented Oct 9, 2023

One specific difference between 1.0 and 1.1 that affects the validator:

  • in version 1.0, the tile.children was allowed to be an empty array
  • in version 1.1, the tile.children has the requirement of minItems: 1 in the schema.

The latter is actually an inconsistency in the spec, tracked at CesiumGS/3d-tiles#752 - depending on how this is resolved, we may consider a special treatment for this case in the validator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant