[SVCS-421] Removing unsizable flag from ResponseStreamReader #273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: https://openscience.atlassian.net/browse/SVCS-421
closes #217
Purpose
The unsizable flag is breaking chunked encoding responses. It is also no longer used and can be removed.
Summary of changes
Removed unsizable flag from ResponseStreamReader
Test Notes/ QA
Git archeology showed that not much had used this flag, or was using it. It seems like googledrive was only ever using it, and that has been changed.
On the Jira ticket, there is a script which tests the difference between the old and new ResponseStreamReader (demonstrating the bug).