Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thumbnail difference between server v2.0.7 and media-scanner #29

Open
dotarmin opened this issue Dec 5, 2018 · 2 comments
Open

Thumbnail difference between server v2.0.7 and media-scanner #29

dotarmin opened this issue Dec 5, 2018 · 2 comments
Assignees
@jnx
Labels
bug Something isn't working

Comments

@dotarmin
Copy link
Contributor

dotarmin commented Dec 5, 2018

Hi!

When decoding the base64 string generated for thumbnails returned by the media-scanner it looks different compared to the thumbnails generated in Server v2.0.7. See attached images for the difference.

Server v2.0.7 thumbnail

heart-207

Thumbnail from media-scanner

heart-220
@dotarmin dotarmin added the bug Something isn't working label Dec 5, 2018
@jnx
Copy link
Collaborator

jnx commented Feb 1, 2019

There seems to be a problem when using thumbnail as a filter in the generation of the thumbnail with FFmpeg.

media-scanner/src/scanner.js

Line 149 in 70d065a

`-vf thumbnail,scale=${config.thumbnails.width}:${config.thumbnails.height}`,

@dotarmin
Copy link
Contributor Author

dotarmin commented Feb 1, 2019 •
edited

How would it be if removing thumbnail filter and using -codec:v png instead and keeping the scaling?

ping @ronag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnx jnx

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jnx @dotarmin