Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change artifact format slightly in v1.0 #176

Open
rkalis opened this issue Dec 20, 2023 · 0 comments
Open

Change artifact format slightly in v1.0 #176

rkalis opened this issue Dec 20, 2023 · 0 comments
Milestone

Comments

@rkalis
Copy link
Member

rkalis commented Dec 20, 2023

Right now the artifact contains "bytecode", which has ASM-formatted bytecode. Because there are multiple ways to represent bytecode as ASM (multiple ASM representations), it is probably better to have "bytecode" be hex-formatted. Then we can add an "asm" field for users to read it easily.

We could add a few lines of code to the CashScript SDK / utils library to be backwards compatible with the old format.

If we wanted to be completely backwards compatible, we could also leave the old "bytecode" field as-is and add a new "bytecodeHex" field (to be used by libraries).

I personally think it is kind of OK to do some backwards incompatible stuff with the artifact format in v1.0 if it means the format is "cleaner" going forward.

Would love to hear more opinions on this.

@rkalis rkalis added this to the v1 milestone Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant