Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 2: description regarding the separation plot for Fig. 2.3.2 #542

Open
beinstein23 opened this issue May 17, 2022 · 0 comments
Open

Comments

@beinstein23
Copy link

beinstein23 commented May 17, 2022

"The black vertical line is the expected number of defects we should observe, given this model. This allows the user to see how the total number of events predicted by the model compares to the actual number of events in the data."
The above ordinates form the paragraph under the first separation plot
https://github.com/CamDavidsonPilon/Probabilistic-Programming-and-Bayesian-Methods-for-Hackers/blob/master/Chapter2_MorePyMC/Ch2_MorePyMC_PyMC2.ipynb
However, I suppose there might be some misunderstandings:
the expected number of defects should be computed by the approach explained in Appendix 2.5, i.e. posterior_probability.sum()
in my case, it's about 6.99753 which corresponds to the number of the realized defect 7.
However, what you computed within separation_plot.py is N - \sum_i p_i , in my case, it about 16.0047.
In my opinion, this makes sense to show how far the blue bar the blue bars should distribute. As you explained in the text: Ideally, all the blue bars should be close to the right-hand side.

But, the description at the beginning of this issue, as I mentioned above, is not exact anymore.
Maybe, we could say:
The black vertical line is the expected number of defects (counting from right-hand side)

Best wishes,

Beinstein.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant