Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordino detail views should not clear state when switching between views #200

Open
mstreit opened this issue Jan 24, 2019 · 4 comments
Open
Labels
type: feature New feature or request type: refactor Refactor the current implementation

Comments

@mstreit
Copy link
Member

mstreit commented Jan 24, 2019

Ordino detail views throw away the settings and state when switching to another detail views. It seems that the view instances are always re-created. It would be nice, if the detail views keep their settings unless something becomes invalid.

@sgratzl
Copy link
Contributor

sgratzl commented Jan 24, 2019

can you make a screencast showing this behavior?

@mstreit
Copy link
Member Author

mstreit commented Jan 24, 2019

@sgratzl
Copy link
Contributor

sgratzl commented Jan 30, 2019

can you move this issue to ordino directly, please

@mstreit mstreit transferred this issue from another repository Jan 30, 2019
@sgratzl
Copy link
Contributor

sgratzl commented Feb 6, 2019

the issue is then when to destroy a view then? especially if you have multiple levels you might end up with a lot of them, each level / lineup can create another series of views.

So far it was not that big of a deal, since some parameter setting will be auto-filled because they were cached for usability thus when "re-opening" the view you end up with the same view

@sgratzl sgratzl added type: feature New feature or request type: refactor Refactor the current implementation labels Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request type: refactor Refactor the current implementation
Projects
None yet
Development

No branches or pull requests

2 participants