Skip to content
This repository has been archived by the owner on Oct 6, 2019. It is now read-only.

Feature request: Uploading JSON file as secret #226

Open
dhulihan opened this issue Jan 5, 2018 · 7 comments
Open

Feature request: Uploading JSON file as secret #226

dhulihan opened this issue Jan 5, 2018 · 7 comments

Comments

@dhulihan
Copy link

dhulihan commented Jan 5, 2018

It would be nice to upload files to goldfish as either a secret (eg: upload a json file with keypairs) or a value of a secret.

The CLI equivalent would be:

# file contents as secret
echo '{ "value": "itsasecret" }' > data.json
vault write secret/password @data.json

and

# file contents as value
vault write secret/password [email protected]
@dhulihan
Copy link
Author

dhulihan commented Jan 5, 2018

This is a feature request, just wanted to start the conversation. Is this a reasonable request @Caiyeon ?

@Caiyeon
Copy link
Owner

Caiyeon commented Jan 5, 2018

I think file uploading and parsing is a little too futuristic for now. I have been meaning to make the secrets page json-compatible though. That is, a user should be able to copy/paste in JSON. I'll leave this open until I'm certain whether it should be implemented or not implemented :)

@Caiyeon Caiyeon changed the title Upload file as secret or value Feature request: Uploading JSON file as secret Jan 5, 2018
@dhulihan
Copy link
Author

dhulihan commented Jan 5, 2018

No worries, just thought I'd capture this idea in a ticket as a point of reference :) .

Editing secrets with json sounds handy too.

Thanks for all your hard work on goldfish! 🔨

@Techcadia
Copy link

I would love to see either of these features. Mostly because we run into developers pasting from their clipboards etc. That contain new lines but break when read from vault in our application.

@Alexey-I
Copy link

I'd love to be able to work with Json too. I'm storing structured data in Vault and have to use 'vault read -> vim -> vault write' operations a lot.

@alexandernst
Copy link

It would be very useful to be able to upload random (small) files, like ssh keys.

@aleks-o
Copy link

aleks-o commented Jul 24, 2018

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants