Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animated GUI textures with repeated frames can desync/freeze when Only Animate Visible Textures is enabled #2514

Open
Cart3r1234 opened this issue May 21, 2024 · 0 comments
Labels
S-needs-triage Status: Needs triage

Comments

@Cart3r1234
Copy link

Bug Description

When Only Animate Visible Textures is enabled, animated GUI sprites can freeze on frames they shouldn't depending on when you close the GUI. I believe this has to do with using a frame list in the .png.mcmeta, and opening/closing the GUI at specific times based on when repeated frames are playing.

Reproduction Steps

  1. Have an animated GUI sprite with repeat frames listed in the .png.mcmeta. In my case, the animation holds on frame 0 for a while before playing the rest on each loop.
  2. Open the GUI and wait until the animation has progressed past the repeated frames.
  3. Close the GUI when the animation is on a frame that is not repeated
  4. Wait a bit until you think the repeated frames would be playing if the GUI were open
  5. Open the GUI and observe the texture. It will be frozen on the frame you closed the GUI on, and fix itself when the animation loops again.

Here's what it should look like:

correct.mp4

Here's what actually happens:

incorrect.mp4

A few other notes -
This may not be limited to just GUI sprites, but that is all I had time to test.
A way to have specific textures ignore Only Animate Visible Textures would be nice, if feasible. Perhaps an additional optional field in the .png.mcmeta

Log File

latest.log

Crash Report

crash-2024-05-21_05.33.54-client.txt

@Cart3r1234 Cart3r1234 added the S-needs-triage Status: Needs triage label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-needs-triage Status: Needs triage
Development

No branches or pull requests

1 participant