Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command permission changing #249

Open
Innectic opened this issue Mar 6, 2017 · 5 comments
Open

Command permission changing #249

Innectic opened this issue Mar 6, 2017 · 5 comments
Labels
Milestone

Comments

@Innectic
Copy link
Member

Innectic commented Mar 6, 2017

!command add test Testing!
!command permission +test

Syntax isn't final

@Innectic Innectic added this to the v0.4.1 milestone Mar 6, 2017
@2Cubed
Copy link
Member

2Cubed commented Mar 6, 2017

What if we instead used rename?

!command rename stuff things
!command rename test +test

You wouldn't have to specify the + for the old name, but you could optionally supply it for the new one to change permissions.

@Alkali-Metal
Copy link
Contributor

Personally I feel as though this is would be better as a separate Magic:tm: command for easier integration with other services and also being able to do it with other magic commands. (See 175 for example)

@Innectic
Copy link
Member Author

Innectic commented Mar 7, 2017

@2Cubed That's a much better way

@Innectic
Copy link
Member Author

Innectic commented Mar 7, 2017

@Alkali-Metal This should stay part of the command command because it changes something about commands. Changing built-in command permissions can still happen using this command, it just needs to be implemented.

@Alkali-Metal
Copy link
Contributor

Alkali-Metal commented Mar 7, 2017

@Innectic it just feels clunky in my opinion to have a !command command changing built-ins. and with using the !config command it could make it easier to understand that it changes both to people who are new to CactusBot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants